Fix browser boltAgent in web workers context
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver was trying to access the `window` object inside web workers. This object doesn't exist in this context. So, the driver was throwing an error and not creating connections at all. This problem is solved by access the `navigator` directy from the global scope (which is the `window` outside the web workers). Some guards were added to avoid the code break in case `navigator` is not defined.
ConorNeo
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver was trying to access the
windowobject inside web workers. This object doesn't exist in this context.So, the driver was throwing an error and not creating connections at all.
This problem is solved by access the
navigatordirectly from the global scope (which is thewindowoutside the web workers). Some guards were added to avoid the code break in casenavigatoris not defined.